Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-805: Adjust text in new app warning text #38

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Oct 29, 2024

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@hnnsgstfssn hnnsgstfssn changed the title Adjust text in new app warning text SD-805: Adjust text in new app warning text Oct 29, 2024
@hnnsgstfssn
Copy link

Changed title to see if that links it in Jira; would be nice to have it linked.

Copy link

@hnnsgstfssn hnnsgstfssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd ask input from the reporter to verify if it resolves the initial confusion. Otherwise good.

@Oded-B
Copy link
Collaborator Author

Oded-B commented Oct 29, 2024

I'd ask input from the reporter to verify if it resolves the initial confusion. Otherwise good.

The new phrasing was suggested by the reporter according the Jira ticket, so we should be good

@Oded-B Oded-B merged commit d34cacf into main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants