Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argocd diff #4

Merged
merged 64 commits into from
Apr 25, 2024
Merged

Argocd diff #4

merged 64 commits into from
Apr 25, 2024

Conversation

Oded-B
Copy link
Collaborator

@Oded-B Oded-B commented Apr 25, 2024 •
edited
Loading

Description

Optionally add ArgoCD "diff" comment on PRs
Light refactoring of the promotion logic to allow ArgoCD functionality to re-use of generateListOfRelevantComponents
re-applying PR #3 after a failed to squash it :)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Oded-B and others added 30 commits March 14, 2024 13:29
@Oded-B
Update docker-publish.yml
896ed6e
@Oded-B
Update docker-publish-on-comment.yml
ede9306
@Oded-B
Allow nesting of components in subdirs
96b7207
@Oded-B
Document new configuration key
506b8a0
@Oded-B
Revert "Update docker-publish-on-comment.yml"
082a359 
This reverts commit ede9306.
@Oded-B
Revert "Update docker-publish.yml"
72354b7 
This reverts commit 896ed6e.
@Oded-B
Merge branch 'wayfair-incubator:main' into main
e159e49
@Oded-B
Test GHA syntax issue
064e5ae
@Oded-B
Another test
b49a364
@Oded-B
3rd test of GHA syntax
9506b7d
@Oded-B
4th try
7835b14
@Oded-B
5th
700f9db
@Oded-B
Document forked repo image publishing
3129459
@Oded-B
Merge pull request #2 from commercetools/forked_repo_image_publish_doc
38a22cb 
Document forked repo image publishing
@Oded-B
Merge branch 'wayfair-incubator:main' into main
f271a4e
@Oded-B
Fix lint issue
3f351c5
@Oded-B
Add some debug logs
2e2a2b2
@Oded-B
Match yaml key name to config
1b35c2c
@Oded-B
Remove unneeded debug messages
79b7332
@Oded-B
Fix documentation
980c864
@Oded-B
Exclude markdown lint rule (I want that newline!)
66f8aed
@Oded-B
Fix syntax issue
6d20860
@Oded-B
Markdown syntax
382d4e7
@Oded-B
Merge remote-tracking branch 'origin/main' into allow_nesting_of_comp…
f8ff45a 
…onents
@Oded-B
Linter work
43fb7e4
@Oded-B
Merge pull request #1 from commercetools/allow_nesting_of_components
211ffd1 
Allow nesting of components
@Oded-B
Merge branch 'wayfair-incubator:main' into main
4a4c226
@Oded-B
Testing ArgoCD client;
5b3e98e
@Oded-B
tidy
d1bbf6f
@Oded-B
Sync currnet progress
96b0fe1
Oded-B and others added 28 commits April 11, 2024 16:54
@Oded-B
Testing older Argocd version
1d5e111
@hnnsgstfssn
Fix broken build and imports
4d7e7f1
@Oded-B
Add diff from ArgoCD cli
b5ef654
@Oded-B
Got a diff
08dab87
@Oded-B
Full implementation of diffing and commenting logic
82d739b
@Oded-B
Use file based Argocd endpoint config.
7b8edba 
Warn on failure to find apps
@Oded-B
Lint work
9531ed9
@Oded-B
bump go version
804967c
@Oded-B
lint work
f5e3473
@Oded-B
more lint work
a52e105
@Oded-B
bump lint version
002b806
@Oded-B
Merge branch 'wayfair-incubator:main' into main
17a0543
@Oded-B
Merge remote-tracking branch 'origin/main' into argocd-diff
d1ddcb9
@Oded-B
Lint fix
c8992f0
@Oded-B
Use env vars for ArgoCD client config.
12536e9
@Oded-B
Some documentation and refactoring
c574377
@Oded-B
Removed unused code path
f231c2c 
Improved formating in failure cases
@Oded-B
Some refacoring and code doc
bbc1e9c
@Oded-B
moving stuff around
aef665c
@Oded-B
Just moving stuff around
94e309f
@Oded-B
testing go-cmp for diff
6777665
@Oded-B
Add PR diff image to README.md
edd33d1
@Oded-B
Adress PR comments:
e0b9831 
Document env var default values
Remove dead code
Named return value in multiple function
Renaming/spliting of some vars
Switched from  map[relevantComponent]bool) to desribe a set  map[relevantComponent]struct{})
@Oded-B
Address more PR comments:
b344d82 
Add some error handeling
Document some functions
@Oded-B
fix lint issue
4c0fda7
@Oded-B
Lint fix
b6d3e87
@Oded-B @yzdann
fix typo
404293e 
Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com>
@Oded-B
Fix typo in file name
22661b4
@Oded-B Oded-B marked this pull request as ready for review April 25, 2024 08:52
@Oded-B Oded-B merged commit c7be471 into main Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oded-B @hnnsgstfssn