Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-853 increase timeout #40

Merged
merged 1 commit into from
Oct 30, 2024
Merged

SD-853 increase timeout #40

merged 1 commit into from
Oct 30, 2024

Conversation

hnnsgstfssn
Copy link

@hnnsgstfssn hnnsgstfssn commented Oct 30, 2024

Calculating diffs on promotion pull requests like [1] fails since the context is timing out and processing is aborted. This is evident from logs.

    Error getting manifests for app ..., revision ...:
	rpc error: code = DeadlineExceeded desc = context deadline exceeded"
    Error generating diff for component ...:
	rpc error: code = DeadlineExceeded desc = context deadline exceeded"
    Handling of PR event failed: err=getting diff information:
	rpc error: code = DeadlineExceeded desc = context deadline exceeded\n" ...

Increasing the timeout is a short-term fix to mitigate the issue and allow users to get the diff while additional investigation is done to figure out how we can address this better long-term.

[1] https://github.com/commercetools/k8s-gitops/pull/998

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Calculating diffs on promotion pull requests like [1] fails since the
context is timing out and processing is aborted. This is evident from
logs.

    Error getting manifests for app ..., revision ...:
	rpc error: code = DeadlineExceeded desc = context deadline exceeded"
    Error generating diff for component ...:
	rpc error: code = DeadlineExceeded desc = context deadline exceeded"
    Handling of PR event failed: err=getting diff information:
	rpc error: code = DeadlineExceeded desc = context deadline exceeded\n" ...

Increasing the timeout is a short-term fix to mitigate the issue and
allow users to get the diff while additional investigation is done to
figure out how we can address this better long-term.

[1] commercetools/k8s-gitops#998
Copy link

@yzdann yzdann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea about the metrics, but I guess this increase won't lead to resource saturation as we wait longer now.

@hnnsgstfssn
Copy link
Author

I have no idea about the metrics, but I guess this increase won't lead to resource saturation as we wait longer now.

There is this but yeah I don't know either. Given it's short-term and we're going to figure out how to better address it separately, maybe by increasing available resources, I say we go ahead. But good callout.

@hnnsgstfssn hnnsgstfssn merged commit 232cc52 into main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants