Support automatically merging PRs that don't affect target clusters #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchill06
reviewed
May 15, 2024
sunchill06
reviewed
May 15, 2024
sunchill06
reviewed
May 15, 2024
Co-authored-by: Sunil Aggarwal <sunil.aggarwal@commercetools.com>
Co-authored-by: Sunil Aggarwal <sunil.aggarwal@commercetools.com>
Oded-B
changed the title
hnnsgstfssn
reviewed
May 15, 2024
| ghPrClientDetails.PrLogger.Infof("Auto-merging (no diff) PR %d", *eventPayload.PullRequest.Number) | ||
| err := MergePr(ghPrClientDetails, eventPayload.PullRequest.Number) | ||
| if err != nil { | ||
| prHandleError = err |
There was a problem hiding this comment.
Just a thought but non blocking for this, I see this is following convention below but would be shadowed if errors happens there. Could potentially use errors.Join or refactor to avoid it.
There was a problem hiding this comment.
errors.Join == mind blown :)
I'll merge as is because I do log the errors so they are not completely lost but yeah, keeping them all is definitely better
There was a problem hiding this comment.
:0 I didn't even know about errors.Join
TechTime on error wrapping would definitely be killer. ErrorWrapping isn't something I've really picked up. I do love being able to use errors.Is for error pathing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support automaticallyh merging PRs that don't affect target clusters - those usually happen when you change some component configuration that affect only some of the environments.
We still want to merge these to avoid environment drift.
Type of Change
Checklist