Skip to content

Commit

Permalink
fix(deps): update dependency @commercetools-frontend/eslint-config-mc…
Browse files Browse the repository at this point in the history
…-app to v22 (#2973)

* fix(deps): update dependency @commercetools-frontend/eslint-config-mc-app to v22

* fix(misc): fix misc issues caused by the new rulesets

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Salzmann <michael.salzmann@commercetools.com>
  • Loading branch information
renovate[bot] and misama-ct authored Nov 5, 2024
1 parent 1ec85b2 commit 3ca51bc
Show file tree
Hide file tree
Showing 5 changed files with 211 additions and 359 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@changesets/changelog-github": "0.5.0",
"@changesets/cli": "2.27.9",
"@commercetools-frontend/babel-preset-mc-app": "22.35.0",
"@commercetools-frontend/eslint-config-mc-app": "21.25.2",
"@commercetools-frontend/eslint-config-mc-app": "22.35.0",
"@commercetools-local/generator-package-json": "*",
"@commercetools-local/generator-readme": "*",
"@commercetools/github-labels": "1.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/calendar-time-utils/src/calendar-time.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe('getLocalizedDateTimeFormatPattern', () => {
it('should throw and error', () => {
expect(() =>
getLocalizedDateTimeFormatPattern('en', 'unknownFormatType')
).toThrowError(
).toThrow(
"CalendarTime.getLocalizedDateTimeFormatPattern: Unknown format type 'unknownFormatType'"
);
});
Expand Down
2 changes: 2 additions & 0 deletions packages/components/tooltip/src/tooltip.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,8 @@ const TooltipWrapper = forwardRef((props, ref) => (
</div>
));

TooltipWrapper.displayName = 'TooltipWrapper';

TooltipWrapper.propTypes = {
children: PropTypes.node.isRequired,
};
Expand Down
8 changes: 4 additions & 4 deletions packages/components/view-switcher/src/view-switcher.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,10 @@ describe('rendering', () => {
);

screen.getByLabelText('test button 1').click();
expect(handleChange).toBeCalledWith('test-button-1');
expect(handleChange).toHaveBeenCalledWith('test-button-1');

screen.getByLabelText('test button 2').click();
expect(handleChange).toBeCalledWith('test-button-2');
expect(handleChange).toHaveBeenCalledWith('test-button-2');
});

it('should not call onChange when selected option is clicked', () => {
Expand All @@ -112,7 +112,7 @@ describe('rendering', () => {
);

screen.getByLabelText('test button 1').click();
expect(handleChange).not.toBeCalledWith('test-button-1');
expect(handleChange).not.toHaveBeenCalledWith('test-button-1');
});

it('should call onClick when button is clicked', () => {
Expand All @@ -129,7 +129,7 @@ describe('rendering', () => {
);

screen.getByLabelText('Test Button 1').click();
expect(handleClick).toBeCalledWith('test-button-1');
expect(handleClick).toHaveBeenCalledWith('test-button-1');
});

it('should not call onClick when button is active', () => {
Expand Down
Loading

0 comments on commit 3ca51bc

Please sign in to comment.