FCT 1187 - enable filter selection in filters #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e4e544 The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ByronDWall
force-pushed
the
FCT-1187-filter-selection
branch
from
205b1d4
to
61cb170
Compare
ByronDWall
force-pushed
the
FCT-1187-filter-selection
branch
from
a54c483
to
6164e94
Compare
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
misama-ct and
FilPob
and removed request for
a team
ByronDWall
force-pushed
the
FCT-1187-filter-selection
branch
from
6164e94
to
7788ee6
Compare
ByronDWall
commented
Nov 4, 2024
| <Popover.Root defaultOpen={props.isDisabled ? false : props.defaultOpen}> | ||
| <Popover.Root | ||
| defaultOpen={props.isDisabled ? false : props.defaultOpen} | ||
| onOpenChange={(open) => { |
There was a problem hiding this comment.
This removes the filter from being visible in the filters list if the menu is closed and no values have been selected
ByronDWall
commented
Nov 4, 2024
| control: false, | ||
| }, | ||
| onClearAllRequest: { | ||
| control: false, |
There was a problem hiding this comment.
there is no point in showing a control to type in a function, since the text gets escaped by storybook, so the function wouldnt work.
…s are handled by the 'add filters' select input
…o find them in tests, add aria-label to ul containing filter chips in TriggerButton for a11y/easier test targeting, add more complete tests for Footer, TriggerButton, and FilterMenu
…cted filter values containers
…dix dialog to find filter inputs instead of looking for combobox in filters.spec.tsx
…ok controls to allow user to play around with controlling a filter menu, change type for renderSearchComponent prop to ReactNode in filters.tsx
…rappers when parent of custom select menu to allow the select input's options menu to scroll, add max-height to filter-menu dropdowns, update usage example to be more readable and add comments, update story to open filters by default so user doesn't have to click on the filters button to see the list, add filters-with-state fixture for use in VRT, add defaultOpen prop to filters so that the filters list can mount on first render, add VRTs for various open/closed states
* feat(filters): implement filters selection tests, add test helpers * feat(vrt): only defaultOpen a filterMenu if it isnt persisted and there are more locally visible filters than there are visible filters from props --------- Co-authored-by: Byron Wall <byron.wall@commercetools.com>
ByronDWall
force-pushed
the
FCT-1187-filter-selection
branch
from
81957f3
to
4d29ecd
Compare
ddouglasz
approved these changes
Nov 6, 2024
misama-ct
reviewed
Nov 6, 2024
Comment on lines
+125
to
+126
| aria-label={`${filterKey} selected values`} | ||
| aria-live="polite" |
misama-ct
approved these changes
Nov 6, 2024
…ves forwarded ref from radix trigger popover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
Filterscomponent and accompanying documentation and tests. These changes collectively improve the flexibility, functionality, and maintainability of thefilterscomponent package.filterscomponent so that it displays all active filters and allows for adding and removing filters.defaultOpenprop tofiltersso that the filters list can mount on the first render.filterMenucomponent so that the menu opens when a new filter is added to the menu.filterMenucomponent to insure that all menus have a max height ofconstraint10.filterMenubody to scroll if the component rendered in the menu body exceeds the available height.add filtersselect menu options container so that the text input will be fixed, and the options menu will scroll if the options exceed the available height.fixturesfiles to declare inputs and constants for use throughout documentation, storybook, and tests.filtersandfilterMenufiltersfiltersin such a way that it provides a comprehensive example of the component's functionality, by allowing the user to control a specific filter menu with custom controls.filtersjsdoc props to be more concise and informative.docs/description.mdto add a brief description offiltersand the purpose of its core props.docs/usage-example.jsto have a thoroughly commented example of how to implement the component.READMEto be more thorough in documenting usage and props.