FCT-1191: filters: select-inputs: display checkboxes for options in multiselectable select inputs #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89c68aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 98 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ddouglasz
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
ByronDWall and
a team
and removed request for
a team
…boxes-for-options-in-multiselectable-select-inputs
misama-ct
commented
Oct 29, 2024
| props.placeholder || intl.formatMessage(messages.placeholder); | ||
| props.appearance === 'filter' | ||
| ? intl.formatMessage(messages.selectInputAsFilterPlaceholder) | ||
| : props.placeholder || intl.formatMessage(messages.placeholder); |
There was a problem hiding this comment.
Is this correct? When appearance is set to filter, the placeholder prop is essentially ignored.
There was a problem hiding this comment.
Thats a good question 🤔, from the design, it may seem like we want that to be search, but on a second thought now, I think I will change the logic to still capture a provided placeholder from prop. Thank you.
There was a problem hiding this comment.
I made the placeholder prop visible when provided, otherwise, use the default messages provided here: 86acbb5
| return { | ||
| Option: (props) => { | ||
| const { | ||
| // children, - not needed, its just the "label" props content |
There was a problem hiding this comment.
Not sure if this bunch of comments (Line 13-26) is helpful/needed. (I copied the list of available props from react-select docs to figure out what's possible and added some remarks).
There was a problem hiding this comment.
updated here: 86acbb5 thank you
ddouglasz
deleted the
FCT-1191-filters-select-inputs-display-checkboxes-for-options-in-multiselectable-select-inputs
branch
ddouglasz
restored the
FCT-1191-filters-select-inputs-display-checkboxes-for-options-in-multiselectable-select-inputs
branch
11 tasks
…boxes-for-options-in-multiselectable-select-inputs
added 2 commits
November 6, 2024 14:23
…ptions-in-multiselectable-select-inputs' of https://github.com/commercetools/ui-kit into FCT-1191-filters-select-inputs-display-checkboxes-for-options-in-multiselectable-select-inputs
ByronDWall
approved these changes
Nov 6, 2024
| * Returns custom components to be used with react-select, when optionStyle is set to "checkbox" | ||
| */ | ||
| type OptionType = { | ||
| label: string; |
There was a problem hiding this comment.
can the label here be a ReactNode? That would match what is being passed from TOption, and allow for more complex (multiline, etc) options to be displayed
| `background-color: ${designTokens.backgroundColorForInputWhenHovered};`} | ||
| display: flex; | ||
| justify-content: space-between; | ||
| font-size: 14px; |
There was a problem hiding this comment.
I think this can be fontsize20
Suggested change
| font-size: 14px; | |
| font-size: ${designTokens.fontSize20}; |
| display: flex; | ||
| align-items: center; | ||
| font-weight: 400; | ||
| line-height: 18px; |
There was a problem hiding this comment.
Suggested change
| line-height: 18px; | |
| line-height: ${designTokens.lineHeight05}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces new properties to handle optional styling for the select input when used as a filter component. The most important changes include the addition of the
filterappearance option and the incorporation of a search icon when this appearance is selected.This PR is opened also to add any other property we might want to add in the appearance option.
Filter-specific changes: