Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCT-1187 - Filter Selection tests #2979

Merged
merged 2 commits into from
Nov 5, 2024
Merged

FCT-1187 - Filter Selection tests #2979

merged 2 commits into from
Nov 5, 2024

Conversation

valoriecarli
Copy link
Contributor

added a few more unit tests and continued to expand on Filter int tests.

@valoriecarli valoriecarli added the 🚧 Status: WIP Work in progress label Oct 29, 2024
@valoriecarli valoriecarli self-assigned this Oct 29, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 38a1139

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 1:44pm

@ByronDWall ByronDWall changed the base branch from main to FCT-1187-filter-selection October 30, 2024 17:05
@ByronDWall ByronDWall force-pushed the FCT-1187-filter-selection-tests branch from 5289934 to 37e1cbb Compare October 30, 2024 17:10
@valoriecarli valoriecarli force-pushed the FCT-1187-filter-selection-tests branch 2 times, most recently from 61c3ba0 to 1d4611b Compare October 31, 2024 15:43
@valoriecarli valoriecarli marked this pull request as ready for review October 31, 2024 15:56
@valoriecarli valoriecarli requested a review from a team as a code owner October 31, 2024 15:56
@valoriecarli valoriecarli requested review from stephsprinkle, jaikamat, ddouglasz, tylermorrisford, ByronDWall and misama-ct and removed request for a team October 31, 2024 15:56
@valoriecarli valoriecarli added 🙏 Status: Dev Review Waiting for technical reviews and removed 🚧 Status: WIP Work in progress labels Oct 31, 2024
tylermorrisford
tylermorrisford approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@tylermorrisford tylermorrisford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the level of context that others have in the realm of filters, but this looks real nice 🪄

ddouglasz
ddouglasz approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏

@ByronDWall ByronDWall force-pushed the FCT-1187-filter-selection-tests branch from 109e3c7 to fb9bcbf Compare November 4, 2024 19:11
@ByronDWall
feat(vrt): only defaultOpen a filterMenu if it isnt persisted and the…
38a1139 
…re are more locally visible filters than there are visible filters from props
@ByronDWall ByronDWall merged commit aebc5a3 into FCT-1187-filter-selection Nov 5, 2024
5 checks passed
@ByronDWall ByronDWall deleted the FCT-1187-filter-selection-tests branch November 5, 2024 13:50
ByronDWall added a commit that referenced this pull request Nov 5, 2024
@valoriecarli @ByronDWall
FCT-1187 - Filter Selection tests (#2979)
4d29ecd 
* feat(filters): implement filters selection tests, add test helpers

* feat(vrt): only defaultOpen a filterMenu if it isnt persisted and there are more locally visible filters than there are visible filters from props

---------

Co-authored-by: Byron Wall <byron.wall@commercetools.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronDWall ByronDWall ByronDWall approved these changes

@tylermorrisford tylermorrisford tylermorrisford approved these changes

@ddouglasz ddouglasz ddouglasz approved these changes

Assignees

@valoriecarli valoriecarli

Labels
🙏 Status: Dev Review Waiting for technical reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valoriecarli @ddouglasz @tylermorrisford @ByronDWall