Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial import of WPI-{data,control}+CWL analysis #2

Merged
3 commits merged into from
Aug 17, 2020
Merged

initial import of WPI-{data,control}+CWL analysis #2

3 commits merged into from
Aug 17, 2020

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Aug 5, 2020

TODO (in this PR, or another): provide concrete + runnable CWL examples for each pattern that CWL supports directly or indirectly.

Partial fulfilment of #1

@mr-c mr-c requested a review from a user August 5, 2020 14:53
@mr-c
Copy link
Member Author

mr-c commented Aug 5, 2020

Also of interest to @illusional if I remember correctly.

@ghost
Copy link

ghost commented Aug 7, 2020

Very nice analysis @mr-c ! I'm not clear about the organization of the content

  1. Currently this is not linked to from the main Readme. Is the idea that we will link once the content is more complete?
  2. Why is there one Readme under workflow_patterns_initiative and then other under workflow_patterns_initiative/data and neither refers to the other?

Thank you.

@mr-c
Copy link
Member Author

mr-c commented Aug 7, 2020

@kaushik-work Thanks! I've added interstitial links from the main README on down.

@mr-c mr-c changed the title initial import of WPI-data+CWL analysis initial import of WPI-{data,control}+CWL analysis Aug 17, 2020
@mr-c
Copy link
Member Author

mr-c commented Aug 17, 2020

I've added an analysis of CWL against the WPI control patterns

@ghost ghost merged commit 794f96b into master Aug 17, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

Excellent. Thank you for this analysis @mr-c

@mr-c mr-c deleted the wpi_data branch August 18, 2020 06:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant