5661 statistics to badges #5917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! :-) |
|
Hi @nicolas-raoul what should I do with the failing check? or just leave it there? |
nicolas-raoul
requested changes
Nov 4, 2024
There was a problem hiding this comment.
I just tested, it is generally great, I only found these issues:
- Tapping the "featured images" icon shows the "thanks received" tooltip.
- Tapping the "quality images" icon shows the "featured images" tooltip.
- I am pretty sure I have 100+ nearby uploads and zero featured images, but I see this:
If the count was already incorrect in the main branch, then no need to fix the count.
| @@ -370,7 +370,8 @@ | |||
| <string name="delete">Delete</string> | |||
| <string name="Achievements">Achievements</string> | |||
| <string name="Profile">Profile</string> | |||
| <string name="statistics">Statistics</string> | |||
| <string name="statistics">Badges</string> | |||
|
I will check whether unit tests fail in master. If yes then don't worry. |
|
Please do not worry about unit tests, this is tracked at #5921 But do you have time to check #5917 (review) ? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5661
What changes did you make and why?
Transformed the statistics of achievement into badges. Each badge changes to gray and hides its count if the value is 0.
Added badgeRender(Map<ImageView, TextView> badgeMap) function, used to render badges with a filter, and the GrayFilter(ImageView imageView) function applies the gray filter.
Used Google’s FlexboxLayout to enable badges to wrap automatically in the layout.
Added String Badges in Strings.xml, drawable badge_number_background.xml in drawable for displaying.
Tests performed (required)
Tested AchievementsFragmentUnitTests on Medium Phone API 33 (Android 13.0 "Tiramisu" | arm64 emulator).
Screenshots (for UI changes only)
Set badges numbers to 0
None 0 badges