Recalculate weights only on block boundaries #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is an optimization.
bmvbhash()
recalculatesy_mod
,y_frac
,y_int
,weight_top
, andweight_bottom
andx_mod
,x_frac
,x_int
,weight_left
, andweight_right
on every iteration of the outer and inner loops respectively. These variables need to be updated only when the loops cross block boundaries.In this patch we keep track of block boundaries using two new variables
y_mult
andx_mult
.This reduces the number of times the weights must be recalculated from
width * height
tobits ** 2
.