Skip to content

Commit

Permalink
Merge pull request #4453 from nickmango/bug/ack-approval-event
Browse files Browse the repository at this point in the history
[#2655] Activity log for Acknowledgements
  • Loading branch information
nickmango authored Oct 13, 2024
2 parents c52de4a + f0ffb0a commit 615f8f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions cla-backend/cla/models/dynamo_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -5065,6 +5065,7 @@ def set_cla_group_details(event, cla_group_id: str):
try:
project = Project()
project.load(str(cla_group_id))
event.set_event_cla_group_id(cla_group_id)
event.set_event_cla_group_name(project.get_project_name())
event.set_event_project_sfid(project.get_project_external_id())
Event.set_project_details(event, project.get_project_external_id())
Expand Down
2 changes: 1 addition & 1 deletion cla-backend/cla/tests/unit/test_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def test_event_project_id(project):
event_type=event_types.EventType.DeleteProject,
event_cla_group_id=project.get_project_id()
)
assert 'data' in response
assert project.get_project_id() == response['data']['event_cla_group_id']


def test_event_user_id_attribute(user_instance, mock_event):
Expand Down

0 comments on commit 615f8f0

Please sign in to comment.