Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump serverless from 3.32.2 to 3.34.0 in /cla-backend-go #4078

Closed
wants to merge 3 commits into from
Closed

Bump serverless from 3.32.2 to 3.34.0 in /cla-backend-go #4078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60d00a2
CI/CD - EasyCLA - Testing Python Layer Deployment
dealako Aug 30, 2023
540e590
CI/CD - EasyCLA - Testing Python Layer Deployment
dealako Aug 30, 2023
a953ee5
Bump serverless from 3.32.2 to 3.34.0 in /cla-backend-go
dependabot[bot] Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
working-directory: cla-backend
run: |
pip install -r requirements.txt
pip install -r requirements-test.txt

- name: Python Lint
working-directory: cla-backend
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/deploy-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ jobs:
working-directory: cla-backend
run: |
pip install -r requirements.txt


pip install -r requirements-test.txt

- name: Python Lint
working-directory: cla-backend
Expand Down
19 changes: 10 additions & 9 deletions cla-backend-go/.golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ linters-settings:
# default is false: such cases aren't reported by default.
check-blank: true
govet:
check-shadowing: true
fieldalignment: true
revive:
ignore-generated-header: true
enable-all: true
#check-shadowing: true
#fieldalignment: true
revive: # golint was replaced by revive
min-confidence: 0
rules:
# Recommended in Revive docs
Expand All @@ -48,12 +48,14 @@ linters-settings:
goconst:
min-len: 2
min-occurrences: 2
gocyclo:
min-complexity: 40

linters:
disable-all: true
enable:
- revive
- govet
- revive # 'golint' is deprecated (since v1.41.0), replaced by revive
# - govet
- errcheck
- ineffassign
- typecheck
Expand All @@ -63,14 +65,13 @@ linters:
- goimports
- gosec
- megacheck # (staticcheck + gosimple + unused in one linter)
- depguard
- unconvert
- unparam
- unused
- nakedret
#- maligned # The repository of the linter has been archived by the owner. Replaced by govet 'fieldalignment'.
# - depguard # recently, this error is showing up: import '....' is not allowed from list 'Main' (depguard) for all the packages
#- maligned is deprecated (since v1.38.0), replaced by govet 'fieldalignment'.
#- dupl
- bodyclose

issues:
exclude-use-default: false
Expand Down
2 changes: 1 addition & 1 deletion cla-backend-go/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ifeq "$(shell uname -s)" "Linux"
endif

LINT_TOOL=$(shell go env GOPATH)/bin/golangci-lint
LINT_VERSION=v1.51.2
LINT_VERSION=v1.54.2
SWAGGER_DIR=$(ROOT_DIR)/swagger
SWAGGER_BIN_DIR=/usr/local/bin
SWAGGER_TOOL_VERSION=v0.30.3
Expand Down
Loading
Loading