Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on "Museum" page #129

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Changes on "Museum" page #129

merged 3 commits into from
Dec 5, 2024

Conversation

softy-dev
Copy link
Contributor

This PR:

  • Removes the magic number for determining the total amount of required donations to complete the collection;
  • Replaces useEffect with useMemo due to an issue with re-render (it was possible to see the page render with a value and then update immediately);
  • Add numbers next to the filters to indicate donated and not donated values.

Copy link

vercel bot commented Nov 30, 2024

@nekosoffy is attempting to deploy a commit to the stardew Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stardew ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 9:17pm

@jacc jacc merged commit 49151ba into communitycenter:main Dec 5, 2024
3 checks passed
@softy-dev softy-dev deleted the counter branch December 6, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants