Merge pull request #127 from companieshouse/lp-368-update-sdk-patch-c…

…all-arguments LP-368 Patch sdk function call - convert record data into lp model
companieshouse · Jan 8, 2025 · 8e4ad63 · 8e4ad63
2 parents 12f5ba4 + 1c08190
commit 8e4ad63
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,7 +33,7 @@
   "license": "MIT",
   "homepage": "https://github.com/companieshouse/limited-partnerships-web#readme",
   "dependencies": {
-    "@companieshouse/api-sdk-node": "^2.0.219",
+    "@companieshouse/api-sdk-node": "^2.0.220",
     "@companieshouse/ch-node-utils": "^1.3.13",
     "@companieshouse/node-session-handler": "^5.0.1",
     "@companieshouse/structured-logging-node": "^2.0.1",

diff --git a/src/infrastructure/gateway/registration/RegistrationGateway.ts b/src/infrastructure/gateway/registration/RegistrationGateway.ts
@@ -74,17 +74,14 @@ class RegistrationGateway implements IRegistrationGateway {
     registrationType: RegistrationPageType,
     data: Record<string, any>
   ): Promise<void> {
+    const limitedPartnershipBuilder = new LimitedPartnershipGatewayBuilder();
+    limitedPartnershipBuilder.withData(registrationType, data);
+    const limitedPartnership = limitedPartnershipBuilder.build();
+
     const apiCall = {
       service: "limitedPartnershipsService",
       method: "patchLimitedPartnership",
-      args: [
-        transactionId,
-        submissionId,
-        {
-          type: registrationType,
-          data,
-        },
-      ],
+      args: [transactionId, submissionId, limitedPartnership.data],
     };
 
     const response = await makeApiCallWithRetry<