-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hashtree #1238
Conversation
This is really cool! I didn't have time to review it in detail, and I also don't recall exactly how merkle trees are supposed to work, but it's a nice idea, I will go through it probably early next year! |
No hurries! It's just put up there for discussion. Have a great holiday! : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to add a few examples and especially tests
@Licini any progress here? |
@Licini impressive contribution! |
@tomvanmele could you take another look? And if adding an example, where should it go? tutorial.basics or tutorial.advanced? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to LGTM, but is this meant to be serialisable? __data__
seems missing then...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Licini looks good, but would be even better if you add a (minimal) corresponding page in the docs related to this new data structure :)
@Licini ping |
Hey sorry totally forgot about this one for a while..... Added a tutorial now! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
+ Coverage 59.92% 60.01% +0.09%
==========================================
Files 206 207 +1
Lines 22136 22234 +98
==========================================
+ Hits 13264 13343 +79
- Misses 8872 8891 +19 ☔ View full report in Codecov by Sentry. |
@tomvanmele this is a considerable contribution -- what's holding back from merging? |
@jf--- it was merged yesterday |
🤦♂️ |
Adding
HashTree
to compare changes on data structrues. For example: