-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rhino brep trimmed #1313
Rhino brep trimmed #1313
Conversation
@gonzalocasas || @tomvanmele this looks good, only thing that comes to mind if handling precision is following the new The description is not super clear -- @chenkasirer this is fusing a nr of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
actually, sorry i take that back, tolerance handling is indeed wrong... |
if not results: | ||
raise BrepTrimmingError("Trim operation ended with no result") | ||
result = results[0] | ||
capped = result.CapPlanarHoles(TOLERANCE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the signature, tolerance=None
. then tolerance = tolerance or TOL.absolute
, with at the top (if it is not already there) from compas.tolerance import TOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then, finally, capped = result.CapPlanarHoles(tolerance)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomvanmele done.
Just curious why not tolerance=TOL.absolute
in signature? as it returns a float
(immutable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would have also been an option indeed. as long as it is not a hard coded tolerance value...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of tolerance should be updated
@chenkasirer ping |
Hey @jf--- ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RhinoBrep.trimmed
returns now a single brep as a result instead of a list of breps. If no result available aBrepTrimmingError
is raised.This fixes a discrepancy between the
RhinoBrep
implementation and the documented behavior.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.