Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some convenience geometry methods #1338

Merged
merged 9 commits into from
Apr 27, 2024
Merged

Conversation

yck011522
Copy link
Contributor

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@yck011522
Copy link
Contributor Author

PR can close #896

@tomvanmele
Copy link
Member

test fail on ironpython due to a missing fixture it seems

@jf---
Copy link
Contributor

jf--- commented Apr 24, 2024

Cool! @tomvanmele pointed a preference for reverse over flip, I think that's an important point.

@yck011522
Copy link
Contributor Author

I'm slightly inclined to keep the terminology borrowed from Rhino / Grasshopper where

  • Vector (and other non tangible things, such as list) are reversed
  • Lines (and other tangible entity, such as curves, meshes and surfaces) are flipped.

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

about the flip vs reverse, I don't have a strong opinion, whatever you guys think it's best

src/compas/geometry/curves/line.py Outdated Show resolved Hide resolved
Co-authored-by: Gonzalo Casas <casas@arch.ethz.ch>
@yck011522 yck011522 merged commit c2516e9 into main Apr 27, 2024
14 checks passed
@yck011522 yck011522 deleted the feature-some-geometry-methods branch April 27, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants