Make the tolerance class a singleton #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licini
reviewed
Apr 30, 2024
|
|
||
| self._is_inited = True | ||
|
|
||
| if unit is not None: |
There was a problem hiding this comment.
not important.... but i guess unit will never be None because it has a default "M", no?
Licini
reviewed
Apr 30, 2024
src/compas/tolerance.py
Outdated
| @@ -108,8 +114,9 @@ class Tolerance(Data): | |||
| """ | |||
|
|
|||
| def __new__(cls, *args, **kwargs): | |||
| if not hasattr(cls, "_instance"): | |||
| cls._instance = super(Tolerance, cls).__new__(cls) | |||
| if not isinstance(cls._instance, cls): | |||
There was a problem hiding this comment.
mmm... not sure I understand here, under what scenario is this condition triggered? Is it equivalent for if cls._instance is None, or it has some wider purposes?
There was a problem hiding this comment.
is it intended for inherited classes?
There was a problem hiding this comment.
I mean the only possible types for _instance are Tolerance and NoneType, no?
|
btw would it be relevant to mention angular unit ? |
|
@Licini there are indeed more things that have to be added to the tolerance object but perhaps we can already merge the switch to the singleton? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.