Fixed compas_ghpython is not importable in Rhino8
#1391
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
- Coverage 60.25% 60.25% -0.01%
==========================================
Files 207 207
Lines 22251 22257 +6
==========================================
+ Hits 13407 13410 +3
- Misses 8844 8847 +3 ☔ View full report in Codecov by Sentry. |
chenkasirer
changed the title
compas_ghpython is not importable in Rhino8
src/compas/plugins.py
Outdated
| class DummyDotNetException(BaseException): | ||
| pass | ||
|
|
||
| DotNetException = DummyDotNetException |
There was a problem hiding this comment.
why is this done in two steps?
There was a problem hiding this comment.
what do you mean two steps? why I'm not using BaseException directly?
There was a problem hiding this comment.
yes, why not class DotNetException(BaseException): pass
There was a problem hiding this comment.
no other reason except it never crossed my mind :)
src/compas/plugins.py
Outdated
| class DummyDotNetException(BaseException): | ||
| pass | ||
|
|
||
| DotNetException = DummyDotNetException |
There was a problem hiding this comment.
yes, why not class DotNetException(BaseException): pass
compas_ghpythonnot importable in Rhino 8 CPython components, mostly by:compas_rhino.drawingimports withincompas_ghpythoncompas_ghpython.utilities.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.