Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapted import to draw_mesh to newly removed utilities module #22

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Sep 30, 2024

This depends on compas-dev/compas#1391

Removed first-level import for drawing functions in the above PR. Drawing functions are now imported from compas_ghpython.drawing.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing all this!

Co-authored-by: Gonzalo Casas <gonzalocasas@gmail.com>
@chenkasirer chenkasirer merged commit d4992e3 into main Oct 2, 2024
14 checks passed
@chenkasirer chenkasirer deleted the draw_mesh branch October 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants