-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDotMPI and DGEMVMPI implementation #45
Open
CYChenFudan
wants to merge
9
commits into
compas:master
Choose a base branch
from
CYChenFudan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
29aef22
Some first modifications:
CYChenFudan 4b0aea0
Fix the bug in the generation of csf's using rcsfgenerate
CYChenFudan f7968ac
DDOTMPI and DGEMVMPI added in mpiu.f90; Then, DVDSON calls them
CYChenFudan e8efff4
Update matain.f90
76eb371
Modifcations for searching the targeted eigenpairs one by one
CYChenFudan 14ba948
Minor modifications for rmcdhf90/maneig.f90, according to those for gdvd
CYChenFudan ddad394
Minor modification for searching the target eigenpairs one by one.
CYChenFudan 892c594
Comment off the serial module rci90 and rmcdhf90, as dvdson is parall…
CYChenFudan 7e2a0ab
Modifications for Librangular code as suggested by G.G (https://githu…
CYChenFudan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
00. src/tool: Makefile, add "chmod a+x $(GRASP)/bin/rsave" | ||
01. jj2lsj90: In jj2lsj_code.f90, lines 220 and 222 are changed to deal with both parities present. | ||
#02. jj2lsj90: In jj2lsj_code.f90, lines around 850, and lines around 2435, | ||
#modifications for transformation of configurations with empty K-shell, such as | ||
#2s2p, 2lnl, as done in A&A 592, A141(2016). | ||
03. rcsfzerofirst90: In RCSFzerofirst.f90, the number of CSFs in zero-order space | ||
are output. The informations could be used conveniently in RCSF and RCI calculations. | ||
04. rmcdhf90: In newco.f90, weighted average energy is output to monitor the energy convergence. | ||
05. rangular90_mpi: getinf.90 modified for iccut=1 | ||
06. rci90_mpi: setham_gg.f90, only myid=0 reports how far the calculation has proceeded. | ||
07. libdvd90, dvdson.f90: make lines 1119 and 1120 work for convergence | ||
monitor. The output messages are very useful for extremely large-scaled calculations. | ||
08. libdvd90, dvdson.f90: function TSTSEL is modified, so that dvdson performs at least TWO | ||
iteration calculations. Or, error results could be obtained in some cases (in | ||
O-like isoelectronic sequence?). | ||
09. dvdson--mpi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,8 +60,9 @@ SUBROUTINE GETINF | |
do i = 1,nblock | ||
write(istde,*) 'Give ICCUT for block',i | ||
1 READ *, ICCUT(i) | ||
IF ((ICCUT(i) <= 1).OR.(ICCUT(i) >= ncfblk(i))) THEN | ||
WRITE (istde,*) 'GETINF: ICCUT must be greater than 1',& | ||
!cychen IF ((ICCUT(i) <= 1).OR.(ICCUT(i) >= ncfblk(i))) THEN | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest removing these commented out lines with the old code before merging. |
||
IF ((ICCUT(i) < 1).OR.(ICCUT(i) >= ncfblk(i))) THEN | ||
WRITE (istde,*) 'GETINF: ICCUT must be greater than 0',& | ||
' and less than ',ncfblk(i) | ||
WRITE (istde,*) ' please reenter ICCUT:' | ||
GOTO 1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR needs to be brought up to speed with the latest master before merging. E.g.
make_environment_gfortran
is not a thing anymore. I don't think any of the substantial parts of the PR have conflicts though, just the build files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and the changes with copying blas and lapack libraries from a given folder are way too case specific. Better to set e.g. the LD_LIBRARY_PATH flag or let CMake do the job.