Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: setup CMake based build for CI coverage #24

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

compnerd
Copy link
Owner

The lack of CI coverage for CMake based build caused the CMake builds to diverge and regress compared to the SPM builds. Add a second test to ensure that we keep the two build systems in sync.

Copy link
Collaborator

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going, LGTM once the cmake job is passing.

@compnerd
Copy link
Owner Author

compnerd commented Oct 3, 2023

#23 will make the CMake CI work.

compnerd pushed a commit that referenced this pull request Feb 15, 2024
* Implement simple Query.whereField variants

* note the unsupported type in the fatal error
@compnerd compnerd force-pushed the compnerd/cmake branch 21 times, most recently from 77c3b56 to 891921e Compare March 6, 2024 22:27
The lack of CI coverage for CMake based build caused the CMake builds to
diverge and regress compared to the SPM builds. Add a second test to
ensure that we keep the two build systems in sync.
@compnerd compnerd merged commit 529eeff into main Mar 6, 2024
2 checks passed
@compnerd compnerd deleted the compnerd/cmake branch March 6, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants