Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant check in Unitroller::acceptAdmin #203

Open
mrcpol opened this issue Jun 6, 2022 · 1 comment
Open

Redundant check in Unitroller::acceptAdmin #203

mrcpol opened this issue Jun 6, 2022 · 1 comment

Comments

@mrcpol
Copy link

mrcpol commented Jun 6, 2022

msg.sender == address(0) in acceptAdmin() looks redundant.

compound-protocol/contracts/Unitroller.sol

Line 110 in 3affca8

if (msg.sender != pendingAdmin || msg.sender == address(0)) {

Instead, can add newPendingAdmin != address(0) in setPendingAdmin().

compound-protocol/contracts/Unitroller.sol

Line 87 in 3affca8

if (msg.sender != admin) {

@mrcpol
Copy link
Author

mrcpol commented Jun 13, 2022

LOL, scammers everywhere.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrcpol and others