CSTMM-44: This pr fixes the credit note allocation to taxable line items

This issue was introduced with civicrm#29823 This pr does not have any reference to core pr as the code has changed completely since then and this fix is not needed in latest civicrm version
compucorp · Oct 23, 2024 · a953a07 · a953a07
1 parent 16428c2
commit a953a07
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/CRM/Financial/BAO/Payment.php b/CRM/Financial/BAO/Payment.php
@@ -574,11 +574,10 @@ protected static function getPayableLineItems($params, $contribution): array {
         else {
           $lineItems[$lineItemID]['allocation'] = round($lineItems[$lineItemID]['balance'] * $ratio, 2);
         }
+      }
 
-        if (!empty($lineItem['tax_amount'])) {
-          $lineItems[$lineItemID]['tax_allocation'] = round($lineItem['tax_amount'] * ($params['total_amount'] / $contribution['total_amount']), 2);
-        }
-
+      if (!empty($lineItem['tax_amount'])) {
+        $lineItems[$lineItemID]['tax_allocation'] = round($lineItem['tax_amount'] * ($params['total_amount'] / $contribution['total_amount']), 2);
       }
     }