CIWEMB-320: User can optionally record payment for new membership #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The change introduced in this PR makes the recording of payment for associated contributions during new membership registration for a contact optional. The contribution status field has also been removed from the user interface (UI).
Before
Previously, users had the ability to change the membership contribution status from the UI, as the contribution was directly linked to the payment.
After
Now, users can use the
Record Payment
checkbox to decide whether to record a payment or not when creating a new membership registration.When the checkbox is unchecked and no payment will be recorded, and the associated contribution will have no payment linked to it, resulting in a "pending" status.
Simultaneously, the membership registration itself will also have a "Pending" status.
Technical Details
The majority of the changes are related to the visual aspect, with minimal modifications made to the core logic. The alterations are primarily implemented through JavaScript, where payment-related fields are grouped together.
io.compuco.financeextras/js/modifyMemberForm.js
Lines 3 to 10 in a453e59