Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIWEMB-463: Ensure financial item accounting entry has the right status #80

Conversation

olayiwola-compucorp
Copy link
Contributor

Overview

This PR majorly corrects the financial item accounting entry that had the wrong status, and also (UI update) added a separator to the credit note list menu items.

Before

The financial item status for credit note line is 0

  {
    "id": 168,
    "created_date": "2023-08-30 14:35:57",
    "transaction_date": "2023-08-30 00:00:00",
    "contact_id": 22,
    "description": "Contribution Amount - Taax",
    "amount": -40,
    "currency": "GBP",
    "financial_account_id": 15,
    "status_id": 0,
    "entity_table": "financeextras_credit_note_line",
    "entity_id": 8
  }

No separator can be seen between the action items.
Screenshot 2023-09-05 at 09 49 43

After

The financial item status for credit note line is 3 - Unpaid

  {
    "id": 188,
    "created_date": "2023-09-05 09:08:30",
    "transaction_date": "2023-09-05 00:00:00",
    "contact_id": 2,
    "description": "Polikok",
    "amount": -516,
    "currency": "GBP",
    "financial_account_id": 3,
    "status_id": 3,
    "entity_table": "financeextras_credit_note_line",
    "entity_id": 7
  },

A separator can be seen between the action items.
image

@olayiwola-compucorp olayiwola-compucorp merged commit d9240d9 into CIWEMB-15-creditnote-workstream Sep 5, 2023
2 checks passed
@olayiwola-compucorp olayiwola-compucorp deleted the CIWEMB-463-financial-entries branch September 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants