Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Adjustable Compressor Settings #8

Open
splitface2811 opened this issue May 10, 2022 · 2 comments
Open

[Feature Request] Adjustable Compressor Settings #8

splitface2811 opened this issue May 10, 2022 · 2 comments

Comments

@splitface2811
Copy link

I was wondering if it would be possible to add the ability to adjust the settings of the compressor.

It may not be necessary for everyone, but because I'm an audio engineer, I've noticed it doesn't sound great with some content. When, it sounds good, its a god send, I just wish I was able to use it for my entire library.

Thank you.

@conceptualspace
Copy link
Owner

conceptualspace commented May 28, 2022

yea, the compressor is tricky because browsers do different things with the audio under the hood that is not well documented, even with shared APIs. getting it set to a sensible default was a lot of trial and error 😆

that said there are currently 2 parameters enhanceotron sets for the compressor: "threshold" and "knee". it shouldn't be too hard to make these adjustable. maybe i could expose them to the command line in the dev console for the next release, so if you wanted to change them, you could open dev tools and type something like "enhanceotron.compressor.knee = 10". i'm not sure where i would put it in the UI that wouldnt be too confusing

@splitface2811
Copy link
Author

Ah, makes sense.

So if I'm understanding you correctly, the only parameters you can control are the threshold and the knee? The knee isn't super useful for general audio, its more important on single sources, like a kick drum for example. The threshold is one of the most important parameters of a compressor.

I'm not a programmer or a UI designer, though I may be able to give a few suggestions on that, but if you need a hand with the audio side of it, I'd be happy to help. That's my area of expertise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants