chore: simplify app config model, rename function

concord-consortium · Jan 1, 2025 · e9de612 · e9de612
1 parent da12a3c
commit e9de612
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/components/developer-options.tsx b/src/components/developer-options.tsx
@@ -38,7 +38,7 @@ export const DeveloperOptionsComponent = observer(function DeveloperOptions({ass
     fetchAssistants();
   }, [apiConnection.beta.assistants]);
 
-  const handleSetSelectedAssistant = (e: React.ChangeEvent<HTMLSelectElement>) => {
+  const handleSelectAssistant = (e: React.ChangeEvent<HTMLSelectElement>) => {
     const id = e.target.value;
     onSelectAssistant(id);
   };
@@ -52,7 +52,7 @@ export const DeveloperOptionsComponent = observer(function DeveloperOptions({ass
         id="assistant-select"
         data-testid="assistant-select"
         value={selectedAssistant}
-        onChange={handleSetSelectedAssistant}
+        onChange={handleSelectAssistant}
       >
         <option value="mock">Mock Assistant</option>
         {Array.from(assistantOptions?.entries() || []).map(([assistantId, assistantName]) => (

diff --git a/src/models/app-config-model.ts b/src/models/app-config-model.ts
@@ -25,18 +25,16 @@ export const AppConfigModel = types.model("AppConfigModel", {
     width: types.number,
     height: types.number,
   }),
-  mockAssistant: types.maybe(types.boolean),
   mode: types.enumeration<AppMode>("Mode", AppModeValues),
 })
 .volatile((self) => ({
-  isAssistantMocked: self.mode === "development" && self.mockAssistant,
+  isAssistantMocked: self.assistantId === "mock",
 }))
 .actions((self) => ({
   setAssistantId(assistantId: string) {
     self.assistantId = assistantId;
   },
   setMockAssistant(mockAssistant: boolean) {
-    self.mockAssistant = mockAssistant;
     self.isAssistantMocked = self.mode === "development" && mockAssistant;
   }
 }));