Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated .Capabilities.KubeVersion.GitVersion references #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silvestre
Copy link

Deprecated: use KubeVersion.Version
https://github.com/helm/helm/blob/82195652495d757d87c1a01f640973f20ca141b0/pkg/chartutil/capabilities.go#L82-L83

Existing Issue

No, I was just confused by the deprecated references while reading the chart

Why do we need this PR?

Just to remove a use of deprecated helm-builtin

Changes proposed in this pull request

  • s/.Capabilities.KubeVersion.GitVersion/.Capabilities.KubeVersion.Version/

Contributor Checklist

  • Variables are documented in the README.md
  • Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

@ns0092
Copy link

ns0092 commented Jan 18, 2024

@silvestre
I see reference of .Capabilities.KubeVersion.GitVersion in a few other places too. Like worker-policy.yaml here:

{{- if semverCompare ">=1.21-0" .Capabilities.KubeVersion.GitVersion -}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants