Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build number to 1 and rebuilt with blasfeo 0.1.4 to enable macOS builds #5

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor Author

traversaro commented Jan 7, 2025

Actually I just noticed that the casadi build has the following warning:

2024-12-16T20:50:19.1302702Z WARNING (casadi,lib/libcasadi_nlpsol_fatrop.so.3.7): Needed DSO lib/libblasfeo.so found in ['conda-forge/linux-64::libblasfeo==0.1.3=had105d5_303']
2024-12-16T20:50:19.1303922Z WARNING (casadi,lib/libcasadi_nlpsol_fatrop.so.3.7): .. but ['conda-forge/linux-64::libblasfeo==0.1.3=had105d5_303'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

so we risk of breaking casadi if we first do not fix this warning.

@traversaro
Copy link
Contributor Author

Actually I just noticed that the casadi build has the following warning:

2024-12-16T20:50:19.1302702Z WARNING (casadi,lib/libcasadi_nlpsol_fatrop.so.3.7): Needed DSO lib/libblasfeo.so found in ['conda-forge/linux-64::libblasfeo==0.1.3=had105d5_303']
2024-12-16T20:50:19.1303922Z WARNING (casadi,lib/libcasadi_nlpsol_fatrop.so.3.7): .. but ['conda-forge/linux-64::libblasfeo==0.1.3=had105d5_303'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

so we risk of breaking casadi if we first do not fix this warning.

This will be fixed by conda-forge/casadi-feedstock#127 .

@traversaro traversaro changed the title Bump build number to 1 and rebuilt with blasfeo 0.1.4 to enable Windows and macOS builds Bump build number to 1 and rebuilt with blasfeo 0.1.4 to enable macOS builds Jan 7, 2025
@traversaro
Copy link
Contributor Author

Windows support still requires some work (see meco-group/fatrop#25), so for now we can just enable macos.

@traversaro traversaro mentioned this pull request Jan 7, 2025
1 task
@traversaro traversaro merged commit 16bd07b into conda-forge:main Jan 7, 2025
9 checks passed
@traversaro traversaro deleted the addwinmacos branch January 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants