Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for ogre 1.12 #19

Closed
wants to merge 1 commit into from
Closed

Build for ogre 1.12 #19

wants to merge 1 commit into from

Conversation

Tobias-Fischer
Copy link
Contributor

Checklist

Fix #15

I am not sure whether it's a good idea to bump ogre to 1.12 for everyone, or if it's better to create two branches, one for ogre 1.10 and another for ogre 1.12. In case of multi branches, I have no idea how to deal with the version numbers etc.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

traversaro commented Jun 7, 2020

I am not sure whether it's a good idea to bump ogre to 1.12 for everyone, or if it's better to create two branches, one for ogre 1.10 and another for ogre 1.12. In case of multi branches, I have no idea how to deal with the version numbers etc.

Hi @Tobias-Fischer ! As (I think) one of the few users of Gazebo built with Ogre 1.12 (in https://github.com/robotology/robotology-superbuild-dependencies-vcpkg), there are several downsides in using Ogre 1.12 for now (some of them are discussed in gazebosim/gazebo-classic#2726):

So Gazebo11+Ogre1.12 usable, but if you can choose probably Ogre 1.10 is still the safe choice.

@Tobias-Fischer
Copy link
Contributor Author

Hey @traversaro,
Good to hear from you! Thanks for those insights - I wasn't aware that @wolfv previously tried to build Gazebo with Ogre 1.12. We better wait for better support / more fixes from Gazebo then, there does not seem to be much point to take this PR any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build for ogre 1.12
3 participants