Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase build number to fix protobuf issues #6

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Increase build number to fix protobuf issues #6

merged 1 commit into from
Jun 9, 2020

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Jun 7, 2020 •
edited
Loading

Checklist

Needs rebuild - conda-forge/gazebo-feedstock#19 fails because of a changes in the protobuf API, see protocolbuffers/protobuf#7522 and protocolbuffers/protobuf#7496 and osrf/homebrew-simulation#1042

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

Tobias-Fischer commented Jun 7, 2020 •
edited
Loading

These builds should pick up protobuf 3.12.3 (see conda-forge/protobuf-feedstock@765d65d) so that downstream packages are fixed. Just checked, they do.

@Tobias-Fischer
Copy link
Contributor Author

This is ready to be merged.

@seanyen
Copy link
Contributor

seanyen commented Jun 9, 2020

LGTM.

@seanyen seanyen merged commit 0341204 into conda-forge:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@seanyen seanyen Awaiting requested review from seanyen

@traversaro traversaro Awaiting requested review from traversaro

@wolfv wolfv Awaiting requested review from wolfv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tobias-Fischer @conda-forge-linter @seanyen @j-rivero