Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport run_exports #320

Closed
ZzEeKkAa opened this issue Jul 19, 2024 · 5 comments
Closed

Backport run_exports #320

ZzEeKkAa opened this issue Jul 19, 2024 · 5 comments
Labels

Comments

@ZzEeKkAa
Copy link

Comment:

Is it possible to backport changes in #313 ? It would be nice to have it numpy 1.19 - 1.26

@h-vetinari
Copy link
Member

Not sure what you're asking here. Numpy in conda-forge has had run-exports since 1.19, but the compatibility (i.e. the version constraints in the numpy run-export) changed fundamentally with numpy 2.0, and cannot be backported.

@jakirkham
Copy link
Member

Could you please share more about the issue you are encountering?

@ZzEeKkAa
Copy link
Author

Oh, okay, I just assumed that abi compatibility was for a while. In other words I was assuming if project was compiled with any python version 1.19 - 1.26 it will be compatible with >=1.19,<2, not >=compiled version,<2. If it is the case only starting from the v2, then there is no issue.

@jakirkham
Copy link
Member

No NumPy didn't introduce the new ABI compatibility until NumPy 1.25.0

We discussed whether we wanted to change things then ( conda-forge/conda-forge-pinning-feedstock#4816 ). However we decided it wasn't worth the effort as we could do this with NumPy 2 (when we already would need to change things)

So the approach we are taking is rebuild everything with NumPy 2 (as we need to anyways) and use the new ABI there. The packages produced work on NumPy 1 & 2, which is a bigger benefit for users then slightly more compatibility with NumPy 1 versions (and no NumPy 2 support)

@ZzEeKkAa
Copy link
Author

Yes, that totally makes sense! Thank you for explaining!

@ZzEeKkAa ZzEeKkAa closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants