Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10arm migration #42

Merged
merged 6 commits into from
Apr 23, 2021
Merged

1.10arm migration #42

merged 6 commits into from
Apr 23, 2021

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Apr 18, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

@Tobias-Fischer
Copy link
Contributor Author

Here's the relevant fix: OGRECave/ogre@0873244

@wolfv
Copy link
Member

wolfv commented Apr 19, 2021

we could also go for Ogre 1.12 only for M1?

And only allow ignition gazebo? I think Traditional Gazebo was holding us back in general, right? (cc @traversaro)

@wolfv
Copy link
Member

wolfv commented Apr 19, 2021

The screenshot I posted of RViz running on M1 was using 1.12 I think.

@traversaro
Copy link
Contributor

And only allow ignition gazebo? I think Traditional Gazebo was holding us back in general, right? (cc @traversaro)

Actually also Classic Gazebo should work finish with Ogre 1.12, just a few rendering features are disabled (gazebosim/gazebo-classic#2686). There were some issues in the past (see gazebosim/gazebo-classic#2700), but hopefully they are not relevant anymore.

@Tobias-Fischer
Copy link
Contributor Author

Hmmm, I think in this case we should try and get Gazebo11 working with Ogre 1.12 on the remaining platforms as well? In my opinion, we should avoid making exceptions as much as possible to avoid issues down the line.

@Tobias-Fischer
Copy link
Contributor Author

I patched ogre 1.10 anyhow as it was easy enough, and if we want to, we can merge. I guess it doesn't hurt merging, even if we don't end up using it.

@Tobias-Fischer Tobias-Fischer merged commit 7de6ed3 into conda-forge:1.10 Apr 23, 2021
@Tobias-Fischer Tobias-Fischer deleted the 1.10arm branch April 23, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants