-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.10arm migration #42
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.04.17.14.54.41
Seems like this needs patching https://github.com/OGRECave/ogre/blob/v1.10.12/OgreMain/src/OgrePlatformInformation.cpp |
Here's the relevant fix: OGRECave/ogre@0873244 |
we could also go for Ogre 1.12 only for M1? And only allow ignition gazebo? I think Traditional Gazebo was holding us back in general, right? (cc @traversaro) |
The screenshot I posted of RViz running on M1 was using 1.12 I think. |
Actually also Classic Gazebo should work finish with Ogre 1.12, just a few rendering features are disabled (gazebosim/gazebo-classic#2686). There were some issues in the past (see gazebosim/gazebo-classic#2700), but hopefully they are not relevant anymore. |
Hmmm, I think in this case we should try and get Gazebo11 working with Ogre 1.12 on the remaining platforms as well? In my opinion, we should avoid making exceptions as much as possible to avoid issues down the line. |
I patched ogre 1.10 anyhow as it was easy enough, and if we want to, we can merge. I guess it doesn't hurt merging, even if we don't end up using it. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)