Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freethreading support #78

Merged
merged 3 commits into from
Oct 15, 2024
Merged

freethreading support #78

merged 3 commits into from
Oct 15, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 10, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Support for freethreading was added in 6.0.0

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Oct 14, 2024

@jakirkham, can you review?

@jakirkham
Copy link
Member

Thanks Isuru! 🙏

It looks like there are a couple patches that didn't make it into 6.0.0 that we may want to include:

@isuruf
Copy link
Member Author

isuruf commented Oct 14, 2024

I added the first patch. The second one was needed for the first two rc builds and it isn't needed anymore because of python/cpython#112778

@jakirkham
Copy link
Member

Thanks Isuru! 🙏

Looking upstream am seeing this later change ( python/cpython#115850 ), which suggests extensions need to pass /DPy_GIL_DISABLED. So am wondering if this is what the author of PR ( giampaolo/psutil#2442 ) encountered

Admittedly I've not dug into this as much as you. So am open to trying things with the off chance this may need a follow up later

@isuruf
Copy link
Member Author

isuruf commented Oct 15, 2024

No, the freethreaded build in conda-forge has

#ifndef Py_GIL_DISABLED
#define Py_GIL_DISABLED 1
#endif

so that macro is not required to be set.

@jakirkham
Copy link
Member

jakirkham commented Oct 15, 2024

@jakirkham jakirkham merged commit 6a61650 into conda-forge:main Oct 15, 2024
39 checks passed
@jakirkham
Copy link
Member

Thanks again Isuru! 🙏

@isuruf isuruf deleted the freethreading branch October 15, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants