Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagelib v10.3 #174

Merged
merged 40 commits into from
May 15, 2024
Merged

sagelib v10.3 #174

merged 40 commits into from
May 15, 2024

Conversation

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@saraedum
Copy link
Member

It's maybe a good idea to use this opportunity to simplify the build script somewhat to what Arch does, sagemath/sage#36860 (comment)

@saraedum
Copy link
Member

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 3 commits April 19, 2024 11:57
@saraedum saraedum closed this Apr 19, 2024
@saraedum saraedum reopened this Apr 19, 2024
@conda-forge-webservices

This comment was marked as outdated.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

saraedum and others added 10 commits April 22, 2024 15:01
not sure why the global numpy pin is not picked up here (in the outputs.)
Anyway, the build script searches for numpy to add it so some search
path. If it's not found, it does nothing, so it is probably not to add
numpy.
This reverts commit 4e04e04.
The error

setuptools.sandbox.UnpickleableException: DistutilsSetupError("each element of 'ext_modules' option must be an Extension instance or 2-tuple")

seems to be caused by a conflict between setuptools and distutils.

It's unclear why that error shows up but maybe dropping distutils here
helps.
and hopefully fix macOS build errors of sagemath-bliss and
sagemath-sirocco.
@saraedum
Copy link
Member

@isuruf, there are a lot of warnings of the kind:

2024-04-23T00:51:14.8933508Z SafetyError: The package for sagelib located at /home/conda/feedstock_root/build_artifacts/pkg_cache/sagelib-10.3-py310h7f17788_0
2024-04-23T00:51:14.8934133Z appears to be corrupted. The path 'lib/python3.10/site-packages/sage/game_theory/__pycache__/cooperative_game.cpython-310.pyc'
2024-04-23T00:51:14.8934549Z has an incorrect size.
2024-04-23T00:51:14.8934864Z   reported size: 33136 bytes
2024-04-23T00:51:14.8935158Z   actual size: 33395 bytes

Is that anything to worry about?

@saraedum
Copy link
Member

Also, I'm a bit surprised about this bit at the end of sagemath-bliss:

2024-04-23T00:50:41.5504111Z Successfully installed sagemath-bliss-10.3
2024-04-23T00:50:41.5530988Z 1 location(s) to search for versions of pip:
2024-04-23T00:50:41.5531684Z * https://pypi.org/simple/pip/
2024-04-23T00:50:41.5549678Z Fetching project page and analyzing links: https://pypi.org/simple/pip/
2024-04-23T00:50:41.5561786Z Getting page https://pypi.org/simple/pip/
2024-04-23T00:50:41.5576385Z Found index url https://pypi.org/simple/
2024-04-23T00:50:41.5598981Z Looking up "https://pypi.org/simple/pip/" in the cache
2024-04-23T00:50:41.5605688Z Request header has "max_age" as 0, cache bypassed
2024-04-23T00:50:41.5619977Z No cache entry available
2024-04-23T00:50:41.5634013Z Starting new HTTPS connection (1): pypi.org:443
2024-04-23T00:50:41.6060331Z https://pypi.org:443 "GET /simple/pip/ HTTP/1.1" 200 32567
2024-04-23T00:50:41.6093123Z Updating cache with response from "https://pypi.org/simple/pip/"
2024-04-23T00:50:41.6102241Z etag object cached for 1209600 seconds
2024-04-23T00:50:41.6109652Z Caching due to etag
2024-04-23T00:50:41.6169581Z Fetched page https://pypi.org/simple/pip/ as application/vnd.pypi.simple.v1+json
2024-04-23T00:50:41.6343034Z   Found link https://files.pythonhosted.org/packages/3d/9d/1e313763bdfb6a48977b65829c6ce2a43eaae29ea2f907c8bbef024a7219/pip-0.2.tar.gz (from https://pypi.org/simple/pip/), version: 0.2
[...]

@saraedum

This comment was marked as resolved.

@alexjbest
Copy link

@isuruf, there are a lot of warnings of the kind:

2024-04-23T00:51:14.8933508Z SafetyError: The package for sagelib located at /home/conda/feedstock_root/build_artifacts/pkg_cache/sagelib-10.3-py310h7f17788_0
2024-04-23T00:51:14.8934133Z appears to be corrupted. The path 'lib/python3.10/site-packages/sage/game_theory/__pycache__/cooperative_game.cpython-310.pyc'
2024-04-23T00:51:14.8934549Z has an incorrect size.
2024-04-23T00:51:14.8934864Z   reported size: 33136 bytes
2024-04-23T00:51:14.8935158Z   actual size: 33395 bytes

Is that anything to worry about?

Whenever I saw that error before as a user I ended up with a subtly broken install of sage, so this does seem a bit worrying to me!

@isuruf
Copy link
Member

isuruf commented Apr 23, 2024

Does sage compile pyc files on first start manually?

@saraedum
Copy link
Member

saraedum commented Apr 23, 2024

Does sage compile pyc files on first start manually?

I don't know. There's some weird stuff in the startup like a function that caches the result of * imports.

There's no reference to py_compile in SageMath 10.2 10.3 at least.

@saraedum
Copy link
Member

saraedum commented May 3, 2024

Since we seem to have no idea what's going on here, shall we just merge and test?

Any objections @isuruf, @alexjbest ?

@saraedum
Copy link
Member

I'll just merge this then. If we find problems, we'll fix them later.

@saraedum saraedum merged commit 901e27e into conda-forge:main May 15, 2024
14 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 10.3_h54e442 branch May 15, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove run dependencies
4 participants