Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pylhe recipe #19135

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 3, 2022

Resolves scikit-hep/pylhe#128

Recipe generated with grayskull v1.3.1.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pylhe) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Jun 3, 2022

GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.

@lukasheinrich @eduardo-rodrigues Can you please comment here that you confirm that you're willing to be a co-mainainter of the recipe with me?

@eduardo-rodrigues
Copy link

GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.

@lukasheinrich @eduardo-rodrigues Can you please comment here that you confirm that you're willing to be a co-mainainter of the recipe with me?

OK :).

@eduardo-rodrigues
Copy link

Hello @matthewfeickert, let me know if you need help here now that you released pylhe 0.4.0. In any case I will add pylhe to scikit-hep once this is ticked off :-).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pylhe) and found some lint.

Here's what I've got...

For recipes/pylhe:

  • requirements: host: setuptools>=61.0.0 must contain a space between the name and the pin, i.e. setuptools >=61.0.0
  • requirements: host: setuptools_scm>=7.0.1 must contain a space between the name and the pin, i.e. setuptools_scm >=7.0.1

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pylhe) and found it was in an excellent condition.

@matthewfeickert matthewfeickert marked this pull request as ready for review September 7, 2022 12:43
@matthewfeickert
Copy link
Member Author

@conda-grayskull show requirements

@conda-grayskull
Copy link

Working on your request...

@marcelotrevisani
Copy link
Member

I am not sure if this bot will work, I still need to fix a few things in it, sorry :/

@matthewfeickert
Copy link
Member Author

I am not sure if this bot will work, I still need to fix a few things in it, sorry :/

That's fine! I was more trying it out just to see if it could pick up things in a staged-recipes request or only on a feedstock given https://twitter.com/mdtrevisani/status/1487894867799859201.

@matthewfeickert
Copy link
Member Author

@chrisburr this should be ready for review.

@chrisburr chrisburr merged commit badb317 into conda-forge:main Sep 7, 2022
@matthewfeickert matthewfeickert deleted the feat/add-pylhe-recipe branch September 7, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add pylhe to Conda
6 participants