Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for nearpy #4129

Merged
merged 4 commits into from
Oct 15, 2017
Merged

Added recipe for nearpy #4129

merged 4 commits into from
Oct 15, 2017

Conversation

mariusvniekerk
Copy link
Member

@jakirkham Addresses #3858

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nearpy) and found it was in an excellent condition.

@mariusvniekerk
Copy link
Member Author

There are two pending issues to resolve for future versions of this packages

pixelogik/NearPy#67
pixelogik/NearPy#68

# '{{ hash_type }}': '{{ hash_value }}'
# ref: https://github.com/pixelogik/NearPy/issues/67
git_url: https://github.com/pixelogik/NearPy
git_revision: 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the tarball from github. https://github.com/pixelogik/NearPy/releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that stable now? doesn't github change hashes on us every now and then?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nearpy, recipes/yellowbrick) and found some lint.

Here's what I've got...

For recipes/yellowbrick:

  • Feedstock with the same name exists in conda-forge

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nearpy) and found it was in an excellent condition.

@mariusvniekerk
Copy link
Member Author

ping @isuruf

@isuruf isuruf merged commit 6142c65 into conda-forge:master Oct 15, 2017
@jakirkham jakirkham mentioned this pull request Oct 30, 2017
noarch: python
number: 0
# script: python setup.py install --single-version-externally-managed --record=record.txt
script: python setup.py install --single-version-externally-managed --record=record.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the commented version could be dropped in the feedstock.

@jakirkham
Copy link
Member

Thanks @mariusvniekerk and @isuruf.

@mariusvniekerk mariusvniekerk deleted the nearpy branch December 27, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants