WIP: emscripten support #84
Conversation
…nda-forge-pinning 2024.09.07.19.33.02
…f7eb69ba, and conda-forge-pinning 2024.09.09.04.46.35
Suggested-By: Wolf Vollprecht <w.vollprecht@gmail.com>
…f7eb69ba, and conda-forge-pinning 2024.09.10.07.05.45
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml: This is a v1 recipe and not yet lintable. We are working on it! |
…f7eb69ba, and conda-forge-pinning 2024.09.10.07.05.45
|
I think the next step here is to build |
| - bin/zlib.js | ||
| requirements: | ||
| build: | ||
| - if: cross_target_platform == "emscripten-wasm32" |
There was a problem hiding this comment.
why do we need the compiler here if we don't do anything?
There was a problem hiding this comment.
This is an artefact of the conda-build recipe, where the run-exports from the global build don't get forwarded to the outputs, so they need(ed) another build-section to inherit the right REs for libgcc and __glibc.
That it's still here is an artefact of first the translation and me not noticing to remove it so far.
| file: build_global | ||
| # see https://github.com/prefix-dev/rattler-build/issues/1056 | ||
| env: | ||
| CROSS_TARGET_PLATFORM: ${{ cross_target_platform }} |
There was a problem hiding this comment.
this should not be necessary since you are using the cross_target_platform variable in the cache (to determine the requirements). In that sense, you might have found a bug in rattler-build, indeed!
There was a problem hiding this comment.
That was what I was trying to communicate in prefix-dev/rattler-build#1056 😅
There was a problem hiding this comment.
Well you never said that you are using them in the recipe.yaml output. You only showed me bits and pieces from the build script :D
This PR is not immediately meant for merging, but for figuring out what's necessary for emscripten support. Builds on #82 & #83
Rattler-build support (at least for this recipe) still needs a bunch of fixes in our infra, see links in #83; for emscripten we don't have compiler jinja's yet, etc.
Inspired by previous work in emscripten-forge.