Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfile #360

Closed

Conversation

nkaretnikov
Copy link
Contributor

Fixes an issue caused by updated dependencies, which manifests on CI as follows:

YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.

Description

This pull request: fixes a CI dependency issue.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@nkaretnikov nkaretnikov marked this pull request as draft February 2, 2024 07:45
@nkaretnikov

This comment was marked as outdated.

@nkaretnikov

This comment was marked as resolved.

@nkaretnikov
Copy link
Contributor Author

nkaretnikov commented Feb 12, 2024

Tania asked that this PR only updates the lockfile. Other CI fixes will be in separate PRs.

The CI is expected to be broken here because other issues prevent integration tests from succeeding.

You can see that the lockfile error is resolved here because the message mentioned in the top comment doesn't appear anymore. Here's a different PR where the lockfile issue can be observed if you look at the failed job: #370.

@nkaretnikov nkaretnikov added status: in progress 🏗 and removed needs: investigation 🔎 This issue needs more investigation before making a decision status: blocked ⛔️ labels Feb 12, 2024
@nkaretnikov nkaretnikov marked this pull request as ready for review February 12, 2024 15:56
@nkaretnikov nkaretnikov added type: maintenance 🛠 needs: investigation 🔎 This issue needs more investigation before making a decision and removed type: bug 🐛 Something isn't working needs: review 👀 labels Feb 12, 2024
@nkaretnikov nkaretnikov marked this pull request as draft February 17, 2024 15:41
@nkaretnikov

This comment was marked as resolved.

@nkaretnikov
Copy link
Contributor Author

nkaretnikov commented Feb 18, 2024

Closing because this is now part of #372, which fixes all CI issues. All the details are in the linked PR.

@nkaretnikov nkaretnikov removed status: in progress 🏗 needs: investigation 🔎 This issue needs more investigation before making a decision labels Feb 18, 2024
@nkaretnikov nkaretnikov added the area: testing ✅ Design of the test infrastructure and everything related label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI 👷🏽‍♀️ area: testing ✅ Design of the test infrastructure and everything related type: maintenance 🛠
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

1 participant