Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove 'pip install' options in recipes #5541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewfeickert
Copy link

@matthewfeickert matthewfeickert commented Nov 17, 2024

  • Remove --no-deps, --no-build-isolation, and --ignore-installed pip install options in recipes as conda-build will enforce all required pip install options itself at build time.

c.f.

env["PIP_NO_BUILD_ISOLATION"] = "False"
# some other env vars to have pip ignore dependencies.
# we supply them ourselves instead.
env["PIP_NO_DEPENDENCIES"] = True
env["PIP_IGNORE_INSTALLED"] = True

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @matthewfeickert.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1062), and ping the bot to refresh the PR.

@matthewfeickert
Copy link
Author

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1062), and ping the bot to refresh the PR.

I've signed the CLA. Please merge conda/infrastructure#1062.

* Remove --no-deps, --no-build-isolation, and --ignore-installed 'pip install'
  options in recipes as conda-build will enforce all required 'pip install'
  options itself at build time.
* Add corresponding news item.
@matthewfeickert matthewfeickert force-pushed the docs/remove-pip-install-options branch from 9e8eda0 to 9be669d Compare November 17, 2024 07:21
@jezdez
Copy link
Member

jezdez commented Nov 17, 2024

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 17, 2024
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #5541 will not alter performance

Comparing matthewfeickert:docs/remove-pip-install-options (9be669d) with main (0ad4bb6)

Summary

✅ 5 untouched benchmarks

@matthewfeickert matthewfeickert marked this pull request as ready for review November 17, 2024 20:51
@matthewfeickert matthewfeickert requested a review from a team as a code owner November 17, 2024 20:51
@matthewfeickert
Copy link
Author

Thanks for taking care of my CLA, @jezdez. This is ready for review now.

cc @beckermr @kenodegard also given their recent PR review/merge activity.

@jezdez
Copy link
Member

jezdez commented Nov 18, 2024

@matthewfeickert Could you please open a ticket that describes the overarching reason we're doing this, basically what is being discussed in conda/grayskull#582? This would be for record-keeping that this is an ecosystem-wide alignment to remove the explicit pip arguments.

@jezdez
Copy link
Member

jezdez commented Nov 18, 2024

Thanks for taking care of my CLA, @jezdez. This is ready for review now.

cc @beckermr @kenodegard also given their recent PR review/merge activity.

No need to cc anyone, the @conda/builds-tools is automatically assigned and informed.

@matthewfeickert
Copy link
Author

matthewfeickert commented Nov 18, 2024

Could you please open a ticket that describes the overarching reason we're doing this

Sure. Done in Issue #5543.

No need to cc anyone, the @conda/builds-tools is automatically assigned and informed.

Ah cool. I didn't realize that conda had a similar teams system to conda-forge. 👍

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me, but we should wait for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants