-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use $schema
keys for menuinst JSON validation
#5569
base: main
Are you sure you want to change the base?
Conversation
@conda/builds-tools, this is ready for review! 🙏 See conda/menuinst#283 for broader context. |
|
||
|
||
@cache | ||
def _build_validator(url): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we restrict which domains can be provided so they can only come from a series of pre-approved locations? e.g. github.com/conda/menuinst
, schemas.conda.org
, etc. Otherwise users might be able to simply link the equivalent of "allow-everything" schema and bypass these validations. Not that they result in errors, though.
CodSpeed Performance ReportMerging #5569 will not alter performanceComparing Summary
|
Description
Recent changes in menuinst fixed this design issue. We can now safely rely on
$schema
to self-validate the JSON document. As a result,menuinst
is no longer necessary as a dependency either.Checklist - did you ...
news
directory (using the template) for the next release's release notes?