remove logrus and add new interfaces for worker #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+124
to
+154
| ////worker := worker.NewWorker("hello", ProcessBody) | ||
| // | ||
| ////taskClient := client.NewTaskClient(apiClient) | ||
| ////workerFn, _ := worker.GetWorker(ProcessBody) | ||
| ////_ = taskRunner.StartWorker2("hello", workerFn, 1, 1) | ||
| // | ||
| //opts := &client.TaskResourceApiBatchPollOpts{} | ||
| //tasks, _, err := taskClient.BatchPollTask(context.Background(), "hello", opts) | ||
| ////task := model.PolledTask{ | ||
| //// TaskType: "abcd", | ||
| //// InputData: "{}", | ||
| //// OutputData: "{}", | ||
| ////} | ||
| //if err != nil { | ||
| // fmt.Println("Got error ", err.Error()) | ||
| //} | ||
| //fmt.Println("Got", len(tasks)) | ||
|
|
||
| //for i := range tasks { | ||
| // fmt.Println("Task.Id", tasks[i].TaskId) | ||
| // res, err := te.Execute(&tasks[i]) | ||
| // if err != nil { | ||
| // fmt.Println("Error executing process body ", err.Error()) | ||
| // } else { | ||
| // fmt.Println("Response of process body", res) | ||
| // } | ||
| //} | ||
|
|
||
| //data, _ := json.Marshal(task.InputData) | ||
| //jsons := string(data) | ||
| //fmt.Println(jsons) |
There was a problem hiding this comment.
Can we remove this commented code ?
Comment on lines
+60
to
+71
| func (task *PolledTask) ToValue(newValue any) (interface{}, error) { | ||
|
|
||
| bytes, err := task.InputData.MarshalJSON() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| err = json.Unmarshal(bytes, newValue) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return newValue, nil | ||
| } |
There was a problem hiding this comment.
directly unmarshalling task.InputData into newValue
Suggested change
| func (task *PolledTask) ToValue(newValue any) (interface{}, error) { | |
| bytes, err := task.InputData.MarshalJSON() | |
| if err != nil { | |
| return nil, err | |
| } | |
| err = json.Unmarshal(bytes, newValue) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return newValue, nil | |
| } | |
| func (task *PolledTask) ToValue(newValue interface{}) (interface{}, error) { | |
| err := json.Unmarshal(task.InputData, newValue) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return newValue, nil | |
| } |
| func authSettings() *settings.AuthenticationSettings { | ||
| key := "api_key_user_03" | ||
| secret := "api_key_user_03" | ||
| if key != "" && secret != "" { |
There was a problem hiding this comment.
Would we be replacing the key and secret somewhere, else can ignore the checks
sdk/main/main.go
Outdated
| func ProcessBody(body *Data) (*Data, error) { | ||
| if body == nil { | ||
| fmt.Println("Body is nil") | ||
| return nil, nil |
There was a problem hiding this comment.
Suggestion: error standardization maybe in some common file
| @@ -17,6 +17,7 @@ import ( | |||
| "encoding/xml" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/conductor-sdk/conductor-go/sdk/log" | |||
There was a problem hiding this comment.
nitpick: linters could be introduced.
| } | ||
|
|
||
| func ProcessBody2(task *model.Task) (interface{}, error) { | ||
| fmt.Println("executing", task.TaskId) |
There was a problem hiding this comment.
Suggestion: usage of logs instead of print with the correct log level to help in debugging later
| "github.com/conductor-sdk/conductor-go/sdk/worker" | ||
| ) | ||
|
|
||
| type Restaurant struct { |
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
Co-authored-by: Shailesh Padave <shaileshpadave49@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.