Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify environment variable usage #164

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Jan 2, 2025

Changes in this PR

  • Use existing client.NewAPIClientFromEnv() in code example and documentation.
  • Replaced usage of env variables "KEY" "SECRET".

NOTES

Will need to merge for integration tests to work.

@jmigueprieto jmigueprieto self-assigned this Jan 2, 2025
@jmigueprieto jmigueprieto force-pushed the fix/usage-of-env-variables branch from 2027a84 to 9a44e71 Compare January 2, 2025 22:50
@jmigueprieto jmigueprieto changed the title (WIP) Unify environment variable usage. Unify environment variable usage. Jan 3, 2025
@jmigueprieto jmigueprieto marked this pull request as ready for review January 3, 2025 04:32
@jmigueprieto jmigueprieto changed the title Unify environment variable usage. Unify environment variable usage Jan 3, 2025
@jmigueprieto jmigueprieto merged commit 05ae15f into main Jan 3, 2025
1 of 3 checks passed
@jmigueprieto jmigueprieto deleted the fix/usage-of-env-variables branch January 3, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant