-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email verification #49
base: main
Are you sure you want to change the base?
Conversation
…ut the actual email working yet
…ter opening link in email
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
4843458 | Generic High Entropy Secret | 4b8197a | .env | View secret |
4843458 | Generic High Entropy Secret | e10fd81 | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Summary
Allows users to register up to 2 email addresses with their account, a "personal" and "school" address. If a user registers a valid "school" address, this renders their account verified (so we can give them a badge for being a confirmed student). Also grants the ability for users to switch which of these two addresses is their "primary" contact address, and also to delete either of these addresses.
Currently doesn't actually send emails to the addresses to verify; the routes just return the token link directly. These links that
GET /verify-unlink/{token}/
andGET /verify-link/{token}/
return are meant to be opened in the browser, so they return HTML.New changes
GET /verify-link
to fetch a link that allows for linking a new email to a user's account.GET /verify-unlink
to fetch a link that allows for unlinking an email from a user's account.PUT /email
to change the user's preferred "primary" email address.GET /verify-link/{token}/
designed to be opened from an email inbox that links an email to a user's account. Route should handle the link received initially fromGET /verify-link
.GET /verify-unlink/{token}/
designed to be opened from an email inbox that unlinks an email from a user's account. Route should handle the link received initially fromGET /verify-unlink
.openapi.yaml
docs for all new routes.Old changes
GET /users/profile/
to also include information about a user's email verification status, alongside their specific emails.openapi.yaml
docs forGET /users/profile/
to reflect the most recent changes to the route.Notes
GET
requests, even though they are linking/unlinking email addresses for the user's account. They're labeled this way because browsers doGET
requests, and they're meant to be clicked on and opened in a browser. Maybe this needs to be changed?