Transform class references in connect-migrate #1342
Merged
+993
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
* Add additional docs on options Signed-off-by: Steve Ayers <sayers@buf.build> * Remove WKT Signed-off-by: Steve Ayers <sayers@buf.build> * Format Signed-off-by: Steve Ayers <sayers@buf.build> * Update MIGRATING.md Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Steve Ayers <sayers@buf.build> * Update MIGRATING.md Co-authored-by: Timo Stamm <ts@timostamm.de> Signed-off-by: Steve Ayers <sayers@buf.build> --------- Signed-off-by: Steve Ayers <sayers@buf.build> Co-authored-by: Timo Stamm <ts@timostamm.de>
smaye81
approved these changes
Jan 8, 2025
|
CI failures appear to be an issue with npmjs.com.
Everything passes locally, so I'm going to merge. |
timostamm
deleted the
tstamm/Transform-class-references-in-connect-migrate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the connect-migrate command to replace imports for a message class with a schema import, and update:
When the identifier is used elsewhere, add a type import for the message type.
When the message is a well-known type, update to import from
@bufbuild/protobuf/wkt.Before we can merge this, we should: