Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[client] Idempotently and consistently connect #1101

Open
LayneHaber opened this issue May 6, 2020 · 2 comments
Open

[client] Idempotently and consistently connect #1101

LayneHaber opened this issue May 6, 2020 · 2 comments
Assignees
@bohendo @rhlsthrm
Labels
Bug Something isn't working More Info Needed We need more info from the issue submitter p5: Experimental Enhancements and refactors that we want to do/head towards wontfix Wont fix this

Comments

@LayneHaber
Copy link
Contributor

Describe the bug
If you call connect twice, it will create two listeners, nats servers, etc. and cause difficult to detect bugs. This function should be idempotent by default.
@LayneHaber LayneHaber added the Needs Triage Needs to be looked at and prioritized. label May 6, 2020
@ArjunBhuptani ArjunBhuptani added Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. and removed Needs Triage Needs to be looked at and prioritized. labels May 9, 2020
@ArjunBhuptani
Copy link
Member

We should also do other connect-related cleanup tasks here. Example: #920 (closed so that we can consolidate)

@ArjunBhuptani ArjunBhuptani mentioned this issue May 30, 2020
Closed
@ArjunBhuptani ArjunBhuptani changed the title [client] connect idempotent [client] Idempotently and consistently connect May 30, 2020
@ArjunBhuptani ArjunBhuptani added p0 CRITICAL CRITICAL bugfixes and security problems leading to potential loss of funds and removed p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. labels May 30, 2020
@ArjunBhuptani
Copy link
Member

Splitting this into two issues:

  1. This issue will continue the discussion/investigation around connect idempotency. For now, we've decided that this is a WONTFIX because the overhead required to protect users from multiple concurrent connect calls is very high and users should handle this outside the client.
  2. Reopening [client] Clean up finalized apps on connect #920 for proper cleanups on connect

@ArjunBhuptani ArjunBhuptani added More Info Needed We need more info from the issue submitter p5: Experimental Enhancements and refactors that we want to do/head towards wontfix Wont fix this and removed p0 CRITICAL CRITICAL bugfixes and security problems leading to potential loss of funds labels Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bohendo bohendo

@rhlsthrm rhlsthrm

Labels
Bug Something isn't working More Info Needed We need more info from the issue submitter p5: Experimental Enhancements and refactors that we want to do/head towards wontfix Wont fix this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bohendo @rhlsthrm @LayneHaber @ArjunBhuptani