Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

[all] Error handling #1316

Open
LayneHaber opened this issue Jul 15, 2020 · 0 comments
Open

[all] Error handling #1316

LayneHaber opened this issue Jul 15, 2020 · 0 comments
Assignees
@LayneHaber
Labels
Chore Devops or refactoring task p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.

Comments

@LayneHaber
Copy link
Contributor

Expected Behavior

Current Behavior

Error handling is a mess, with the same error being thrown and logged at multiple layers of the stack. Additionally, the logging is overwhelming, making it tough to decipher what is going on in the case of multiple clients and a single node.

Possible Solution

We should create a custom error class and make sure all functions use this, it is bubbled up to the top most layer with all relevant context, and the logging is handled properly.
@LayneHaber LayneHaber added p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. Chore Devops or refactoring task labels Jul 15, 2020
@LayneHaber LayneHaber self-assigned this Jul 15, 2020
@LayneHaber LayneHaber mentioned this issue Aug 19, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LayneHaber LayneHaber

Labels
Chore Devops or refactoring task p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LayneHaber