Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary #1

Open
tbergen1 opened this issue Oct 7, 2019 · 1 comment
Open

Summary #1

tbergen1 opened this issue Oct 7, 2019 · 1 comment

Comments

@tbergen1
Copy link

tbergen1 commented Oct 7, 2019

Rubric Score

Criteria 1: CRA Project Creation & Structure

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): Your file structure is good. You made a CRA app and all of the components are properly located inside of folders, with the file paths working as well. Nice work!

Criteria 2: Data Flow

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You met the requirements for data flow within the app. You did well working with Spotify and showed good understanding of how it worked.

Criteria 3: Syntax

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You hit upon all of the syntax requirements here. You used className when applying classes and used JSX instead of pure HTML. You also added keys to each track in your track list. Lastly, you wrote elegant code for adding and removing tracks. It is great that you remembered to avoid mutating state directly when making updates. Nice work!

Criteria 4: DRY Code/Style

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You did well keeping your code "DRY." One thing I would recommend to enhance it would be to move the base API url into its own variable. This will allow you to replace the base url if the domain every changes for whatever reason. Other than that, nice job!

Overall Score: 16/16

Overall, you did a great job with this project. You implemented all of the features of the project and wrote "DRY" code. Your data flow through the app was great and you did a good job working with the Spotify API. You seem to have taken the lessons to heart and it shows in your work. Great job!

@connorads
Copy link
Owner

Thanks for the review @tbergen1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants